Comments on: Validating URL/URI in Ruby on Rails http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/ A goal is a dream with a deadline. Fri, 04 Jul 2008 03:03:47 +0000 http://wordpress.org/?v=2.5.1 By: Henrik N http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-104088 Henrik N Wed, 18 Jun 2008 14:59:26 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-104088 Ilya: Yeah, I noticed that when I tried it: it allowed e.g. "foo" and "http://foo"… Tried posting an update here but was unable to. Ilya: Yeah, I noticed that when I tried it: it allowed e.g. “foo” and “http://foo”… Tried posting an update here but was unable to.

]]> By: Ilya Grigorik http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-104083 Ilya Grigorik Wed, 18 Jun 2008 12:31:31 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-104083 Henrik, URI.parse uses a very similar regex, and if I remember correctly, it is actually more relaxed than the regular expression I suggested in the original post. Try running a few test URLs through both and then determine which one suits you best. Henrik, URI.parse uses a very similar regex, and if I remember correctly, it is actually more relaxed than the regular expression I suggested in the original post. Try running a few test URLs through both and then determine which one suits you best.

]]> By: Henrik N http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-104081 Henrik N Wed, 18 Jun 2008 10:23:35 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-104081 Rather than a regexp, how about just using URI.parse and rescue URI::InvalidURIError? Rather than a regexp, how about just using URI.parse and rescue URI::InvalidURIError?

]]> By: Ilya Grigorik http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-100708 Ilya Grigorik Thu, 27 Dec 2007 04:57:58 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-100708 Awesome, thanks for sharing the fix Alan. Awesome, thanks for sharing the fix Alan.

]]> By: Alan Lake http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-98679 Alan Lake Sun, 16 Dec 2007 00:56:48 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-98679 I messed with the regexp some more and came up with something that passed all of our tests. It is: <code>validates_uri_existence_of :url, :if => Proc.new {|u| !u.page.blank? }, :allow_nil => true, :with => /(^(http|https):\/\/[a-z0-9]+([-.]{1}[a-z0-9]*)+. [a-z]{2,5}(([0-9]{1,5})?\/.*)?$)/ix </code> I messed with the regexp some more and came up with something that passed all of our tests. It is:
validates_uri_existence_of :url,
:if => Proc.new {|u| !u.page.blank? },
:allow_nil => true,
:with => /(^(http|https):\/\/[a-z0-9]+([-.]{1}[a-z0-9]*)+. [a-z]{2,5}(([0-9]{1,5})?\/.*)?$)/ix

]]> By: Alan Lake http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-98478 Alan Lake Fri, 14 Dec 2007 20:12:37 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-98478 I'm getting a failure where I should not (my web site). I'd appreciate help in fixing it. The only modification that I need is to allow the field to be blank. I'm not really comfortable with regexps, although I think I can read them. I don't understand the "ix" at the end of it. Here's what I have in my models code: validates_uri_existence_of :page, :with => /(^$)|(^(http|https):\/\/[a-z0-9] ([-.]{1}[a-z0-9] )*.[a-z]{2,5}(([0-9]{1,5})?\/.*)?$)/ix, :if => Proc.new {|u| !u.page.blank? }, :allow_nil => true Thanx I’m getting a failure where I should not (my web site). I’d appreciate help in fixing it. The only modification that I need is to allow the field to be blank. I’m not really comfortable with regexps, although I think I can read them. I don’t understand the “ix” at the end of it. Here’s what I have in my models code:
validates_uri_existence_of :page,
:with => /(^$)|(^(http|https):\/\/[a-z0-9] ([-.]{1}[a-z0-9] )*.[a-z]{2,5}(([0-9]{1,5})?\/.*)?$)/ix,
:if => Proc.new {|u| !u.page.blank? },
:allow_nil => true
Thanx

]]> By: Ilya Grigorik http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-93817 Ilya Grigorik Thu, 29 Nov 2007 07:43:23 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-93817 Adam, that's definitely a good idea. Having said that, you don't need to waste space in your database by always keeping the redundant http:// part. Instead, I would recommend stripping it away and then appending it when you display the link back to the user. Adam, that’s definitely a good idea. Having said that, you don’t need to waste space in your database by always keeping the redundant http:// part. Instead, I would recommend stripping it away and then appending it when you display the link back to the user.

]]> By: Adam http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-93130 Adam Tue, 27 Nov 2007 23:23:17 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-93130 Nice work. What if rather than validating that user entered correct URL, you simply created a valid URL for the user. That is, if user supplies "http://www.yahoo.com" you do nothing. If they supply "yahoo.com" you add "http://" Nice work. What if rather than validating that user entered correct URL, you simply created a valid URL for the user. That is, if user supplies “http://www.yahoo.com” you do nothing. If they supply “yahoo.com” you add “http://”

]]> By: Alan Lake http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-92041 Alan Lake Sun, 25 Nov 2007 17:21:30 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-92041 Thank you, Ilya! Thank you, Ilya!

]]> By: Ilya Grigorik http://www.igvita.com/2006/09/07/validating-url-in-ruby-on-rails/#comment-92028 Ilya Grigorik Sun, 25 Nov 2007 16:17:47 +0000 http://www.igvita.com/blog/2006/09/07/validating-urluri-in-ruby-on-rails/#comment-92028 Alan, not sure what happened with the code there, but you're right, that won't run! Here is what it should read instead: <code> configuration = { :message => "is not valid or not responding", :on => :save, :with => nil } configuration.update(attr_names.pop) if attr_names.last.is_a?(Hash) </code> Alan, not sure what happened with the code there, but you’re right, that won’t run! Here is what it should read instead:


configuration = { :message => "is not valid or not responding", :on => :save, :with => nil }
configuration.update(attr_names.pop) if attr_names.last.is_a?(Hash)

]]>